Add validationRegexp field back to catalog.json schema#1757
Open
fangmobile wants to merge 2 commits into
Open
Conversation
not sure whether it is intended. I was using this in 0.9 but now it is gone. Text field validation is important in many input fields. Signed-off-by: fangmobile <fangjian@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new validationRegexp property of type string to the catalog specification, which can be used for client-side validation of inputs. No review comments were provided, so there is no additional feedback to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add validationRegexp back to 1.0 catalog.json schema in TextField
not sure whether it is intended. I was using this in 0.9 but now it is gone. Text field validation is important in many input fields.
Pre-launch Checklist
One time:
For this PR:
If you need help, consider asking for advice on the discussion board.