Add UTS tests for LiveObjects path-based API#2219
Open
paddybyers wants to merge 4 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
👮 Files not reviewed due to content moderation or server errors (23)
Warning Walkthrough skippedFile diffs could not be summarized. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
github-actions
Bot
temporarily deployed
to
staging/pull/2219/bundle-report
github-actions
Bot
temporarily deployed
to
staging/pull/2219/bundle-report
Translate portable UTS test specs from specification/uts/objects/ into working ably-js TypeScript tests covering PathObject, Instance, batch operations, LiveCounter/LiveMap CRDT internals, ObjectsPool sync state machine, RealtimeObject lifecycle, value types, and subscriptions. 19 test files: 14 unit (270 tests), 4 integration (15 tests), 1 proxy fault injection (5 tests). 1 test pending (LiveMap#clear() not yet implemented). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove client-side port allocation (TOCTOU race) and let the proxy auto-assign free ports via OS. Read the assigned port from the session creation response. Update binary to v0.2.0 with new asset naming. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds parentReferences, PublicAPI::ObjectMessage, RTO24/25/26 tests; updates objectMessage/subscription assertions; removes batch API tests. 308 passing, 4 pending deviations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The webpack build type-checks the whole tsconfig program (which
includes test/**/*), so type errors in the UTS LiveObjects tests
failed `npm run build` and therefore `npm ci`.
- Add siteCode and objectsGCGracePeriod to the mock CONNECTED
message's connectionDetails defaults, so tests can set these
real protocol fields without widening a mismatched type.
- Pass the LiveObjects plugin module namespace to `plugins`
instead of the LiveObjects const export, matching the internal
ModularPlugins type (typeof import('plugins/liveobjects')) and
the existing JS tests. Runtime behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specification/uts/objects/into 290 working ably-js TypeScript testsLiveMap#clear()not yet implemented in ably-js)Test plan
npx mocha --no-config --require tsx/cjs 'test/uts/objects/**/*.test.ts' --timeout 60000🤖 Generated with Claude Code