ci: grant deployments:write to features workflow#2252
Merged
Conversation
The sdk-features reusable workflow requires deployments:write and id-token:write. PR #2228 scoped the GITHUB_TOKEN to least privilege but omitted deployments:write, causing an invisible failure at workflow startup. Add the missing permission.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe workflow job permission set was extended to include ChangesWorkflow permissions update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ttypic
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #2228 ("ci: harden workflows") scoped the
GITHUB_TOKENto least privilege. Thefeatures.ymlbuildjob calls the reusable workflowably/features/.github/workflows/sdk-features.yml, which declares it requires:However
features.ymlgranted onlycontents: readandid-token: write— missingdeployments: write. A called reusable workflow cannot request a permission the caller did not grant, so this caused an invisible failure at workflow startup (the Features job never ran).This restores the missing
deployments: writepermission.Background
Flagged by @VeskeR on ably-dotnet#1328, who noted the same regression landed across multiple SDKs (ably-js, ably-python). Broken ably-js run: https://github.com/ably/ably-js/actions/runs/26302842757
Summary by CodeRabbit