[ECO-5582] Added comprehensive unit tests#14
Merged
Merged
Conversation
sacOO7
commented
Oct 8, 2025
sacOO7
commented
Contributor
- Related to Implement full delta decoding support ably-dotnet#1302
sacOO7
force-pushed
the
feature/target-netstandard2.0
branch
from
4b38ad0 to
134fe55
Compare
sacOO7
force-pushed
the
feature/unit-tests
branch
from
8dedf70 to
0bd5fe2
Compare
sacOO7
force-pushed
the
feature/unit-tests
branch
2 times, most recently
from
da456e8 to
e1c9b07
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests using the standardized vcdiff-tests test suite. The changes introduce a structured testing framework with 85 tests across multiple categories to validate the VCDIFF decoder implementation.
Key changes:
- Added git submodule integration for standardized test data
- Implemented comprehensive test suite with multiple test categories (positive, negative, general, and fuzz tests)
- Updated project dependencies and CI configuration to support the new testing infrastructure
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Added detailed setup instructions for git submodules and Windows-specific configuration |
| IO.Ably.DeltaCodec/Vcdiff/IOHelper.cs | Fixed pluralization logic in error message |
| IO.Ably.DeltaCodec.Test/vcdiff-tests | Added git submodule reference for standardized test data |
| IO.Ably.DeltaCodec.Test/VcdiffTestSuiteFixture.cs | New comprehensive test fixture with 85 standardized tests across multiple categories |
| IO.Ably.DeltaCodec.Test/VcdiffDecoderFixture.cs | Updated assertion syntax to modern NUnit style |
| IO.Ably.DeltaCodec.Test/README.md | Added documentation for the new test suite structure and usage |
| IO.Ably.DeltaCodec.Test/IO.Ably.DeltaCodec.Test.csproj | Updated NUnit dependencies and added System.Text.Json package |
| .gitmodules | Added submodule configuration for vcdiff-tests repository |
| .github/workflows/check.yml | Updated CI to clone submodules recursively |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sacOO7
force-pushed
the
feature/unit-tests
branch
from
e1c9b07 to
da95384
Compare
Test Results93 tests 92 ✅ 0s ⏱️ Results for commit 1fa8a47. ♻️ This comment has been updated with latest results. |
sacOO7
force-pushed
the
feature/unit-tests
branch
4 times, most recently
from
ce671e2 to
1fa8a47
Compare
- Added comprehensive unit tests covering edge cases for delta decoding - Integrated vcdiff-tests submodule for standardized test coverage - Updated GitHub CI workflow for recursive checkout with submodules
sacOO7
force-pushed
the
feature/unit-tests
branch
from
1fa8a47 to
690ead8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.