Skip to content

[acknowledgements] Implement RESTful AcknowledgementClient Post functionality#10352

Merged
driusan merged 5 commits intoaces:mainfrom
HenriRabalais:2026-02-09_acknowledgements-create-integration-with-client
Feb 23, 2026
Merged

[acknowledgements] Implement RESTful AcknowledgementClient Post functionality#10352
driusan merged 5 commits intoaces:mainfrom
HenriRabalais:2026-02-09_acknowledgements-create-integration-with-client

Conversation

@HenriRabalais
Copy link
Collaborator

@HenriRabalais HenriRabalais commented Feb 9, 2026

Description

This PR builds off #9999 by incorporting the use of the Acknowledgment Client for POST request handling.

Changes

  • Updated Client.create() to support subEndpoint resolution, allowing POST requests to target specific logic like acknowledgementsprocess.

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: acknowledgements PR or issue related to acknowledgements module labels Feb 9, 2026
@HenriRabalais HenriRabalais added Difficulty: Simple PR or issue that should be easy to implement, review, or test Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test and removed Difficulty: Simple PR or issue that should be easy to implement, review, or test labels Feb 10, 2026
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Feb 17, 2026
@kongtiaowang
Copy link
Contributor

@HenriRabalais please ignore the test failure for now.

@driusan driusan merged commit 4d883b7 into aces:main Feb 23, 2026
93 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Difficulty: Medium PR or issue that require a moderate effort or expertise to implement, review, or test Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: acknowledgements PR or issue related to acknowledgements module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants