Repository navigation
Fix agent rule gaps causing repeated pconfigs mistakes - #11
Merged
Merged
Conversation
Clarify and extend the installed rules and pconfigs-review skill checklist to cover patterns that agents get wrong consistently: pdefaults vs direct construction, @pconfiged necessity, .construct() placement, Pin() misuse, instance file rename exceptions, and config inspection discipline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify and extend the installed rules (
claude_assets/rules/,cursor_assets/rules/) and thepconfigs-reviewskill checklist to cover pconfigs patterns that agents get wrong consistently.Changes to
pconfigs.md:pdefaults(MyConfig)overMyConfig()when wanting defaultsif/eliffactories to pick submodule types__pconfigs__.pysentinels may containTestSubdirsorTestManuallymarkers (not just be empty)Pinned[T]field must have apdefaultsentry set to thePinnedsentinelpinputs(self)vsselfinside@pproperty@penvplacement rule expanded with a code exampleChanges to
policies.md:foo.py→foo/base.py) is the one permitted case; all other renames are notChanges to
pconfigs-review/SKILL.md:Pin(...)only when the target field is typedPinned[T]@pconfigedclass must implement runtime behavior, not just hold a config reference.construct()calls must happen in__init__, not inside methods__pconfigs__.pyfilesRelated Issue
Closes #10
Motivation and Context
Each gap in the rules requires a manual correction loop when an agent violates it. Making the rules explicit and adding checklist items eliminates corrections before they happen.
How Has This Been Tested?
Rules and skill files are documentation — no automated tests apply. The checklist additions were validated against the specific failure modes they address, which were observed across multiple projects before this fix.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: