Repository navigation
Fix select all in multi-select Select - #10977
Open
Bhavani2016 wants to merge 1 commit into
Open
Bhavani2016 wants to merge 1 commit into
Bhavani2016 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10958
Summary
In a Select with selectionMode="multiple", pressing Cmd/Ctrl+A or calling selectionManager.selectAll() leaves the selection unchanged. Both actions produce the 'all' selection value, which useSelectState previously discarded.
Following the approach proposed by the issue reporter, useSelectState converts 'all' to the keys of the enabled options and passes them through the existing selection update. Users can then deselect individual options after selecting all.
📝 Test Instructions
Release impact
✅ PR Checklist
I used ChatGPT to help investigate a issue
🧢 Your Project