Skip to content

Update the Exclude data slider in MetricsDetails page#1237

Merged
smlambert merged 2 commits into
adoptium:masterfrom
dennycjacob:refactor_exclude_slider
Jul 6, 2026
Merged

Update the Exclude data slider in MetricsDetails page#1237
smlambert merged 2 commits into
adoptium:masterfrom
dennycjacob:refactor_exclude_slider

Conversation

@dennycjacob

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented May 25, 2026

Copy link
Copy Markdown

Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit 53ce351
🔍 Latest deploy log https://app.netlify.com/projects/eclipsefdn-adoptium-trss/deploys/6a448cf111dbfd000864aec5
😎 Deploy Preview https://deploy-preview-1237--eclipsefdn-adoptium-trss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dennycjacob

Copy link
Copy Markdown
Contributor Author

Current Behavior:

Screen.Recording.2026-05-25.at.12.33.51.PM.mov


};

// const uniqueTitle = [...new Set(data.map((item) => item.metricName))];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the commented out line uniqueTitle

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@annaibm

annaibm commented May 26, 2026

Copy link
Copy Markdown
Contributor

Suggestion (can be a follow-up issue): The stats calculation logic is duplicated between the useEffect and the table summary function — same math, only difference is CI formatting ("38.47" vs "38.47%"). Could be extracted into a shared calculateStats(values, formatCI) helper so if the formula changes it only needs updating in one place. Happy to open an issue for this if useful.?

@dennycjacob

dennycjacob commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Suggestion (can be a follow-up issue): The stats calculation logic is duplicated between the useEffect and the table summary function — same math, only difference is CI formatting ("38.47" vs "38.47%"). Could be extracted into a shared calculateStats(values, formatCI) helper so if the formula changes it only needs updating in one place. Happy to open an issue for this if useful.?

I think this suggestion can be purued in a different issue,sice this PR only deals with the slider. Its a good suggestion , will create an issue to track this

@karianna karianna requested a review from annaibm July 5, 2026 20:44

@annaibm annaibm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 7e00fbe into adoptium:master Jul 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants