Add /re-enable command to remove OpenJDK test exclusions from ProblemList files#7170
Open
sophia-guo with Copilot wants to merge 2 commits into
Open
Add /re-enable command to remove OpenJDK test exclusions from ProblemList files#7170sophia-guo with Copilot wants to merge 2 commits into
sophia-guo with Copilot wants to merge 2 commits into
Conversation
- Add scripts/disabled_tests/reenable_openjdk.py: new script that
processes /re-enable comments and removes matching exclusion lines
from ProblemList files. Command format:
/re-enable <testcases> <platform> [jdk=<versions>] [impl=<impl>] [variant=<variant>]
- Add scripts/disabled_tests/tests/test_reenable_openjdk.py: unit tests
covering command parsing, target resolution, and line removal logic
- Add reenable-openjdk-test job to .github/workflows/autoTestPR.yml:
triggered by /re-enable comments, mirrors the exclude-openjdk-test
job, creates a PR that removes the exclusion lines and labels the
issue test re-enabled
Closes #7169
Copilot
AI
changed the title
[WIP] Add re-enable command support for OpenJDK test re-enable
Add /re-enable command to remove OpenJDK test exclusions from ProblemList files
Jun 12, 2026
Contributor
|
@Coilot can I do a test now? by adding the command in this comment? |
sophia-guo
approved these changes
Jun 17, 2026
smlambert
reviewed
Jun 18, 2026
smlambert
left a comment
smlambert
left a comment
Contributor
There was a problem hiding this comment.
Can we add userGuide doc with this PR which includes the various assumptions made by this code that gives precedence to variants, etc?
Contributor
|
Also thinking that if this is part of a 'pair' of actions that are related, then the naming could be improved to indicate the relationship such as:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to the existing
/excludecommand:/re-enablelets issue authors and project committers automatically create a PR that removes exclusion lines from OpenJDK ProblemList files.Command format
Examples:
Omitting
jdk=targets all available LTS + latest versions, same as/exclude.Changes
scripts/disabled_tests/reenable_openjdk.py– New script that parses/re-enablecomments and removes matching lines (matched by testcase + platform) from the appropriate ProblemList files. Supports the samejdk,impl, andvariantselectors asexclude_openjdk.py.scripts/disabled_tests/tests/test_reenable_openjdk.py– 27 unit tests covering command parsing, target file resolution, and line removal (including edge cases: wrong platform, missing entry, comment preservation)..github/workflows/autoTestPR.yml– Newreenable-openjdk-testjob triggered by/re-enableissue comments. Mirrors theexclude-openjdk-testjob: permission check → acknowledgement comment → run script → open PR → addtest re-enabledlabel.