Support OData v4 remote models, add a fallback case on UI5BindingPath.getNode/0, fix UI5 AMD module inheritance
#248
Conversation
…getExtendingModule`
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| exists(JsonObject jsonObject | | ||
| jsonObject = resolveDirectPath(this.getArgument(0).getStringValue()) | ||
| ) |
Check warning
Code scanning / CodeQL-Community
Expression can be replaced with a cast
javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
Fixed
Show fixed
Hide fixed
|
|
||
| class RoutingTargetManifest extends JsonObject { | ||
| /** Note: This is NOT its `viewName` property! */ | ||
| string targetName; |
Check notice
Code scanning / CodeQL-Community
Field only used in CharPred
| customController.getAThisNode() = result.getReceiver() and | ||
| result.getMethodName() = "getOwnerComponent" | ||
| or | ||
| exists(TypeTracker t2 | result = getOwnerComponentRef(t2, customController).track(t2, t)) |
Check warning
Code scanning / CodeQL-Community
Var only used in one side of disjunct.
| exists(TypeTracker t2 | result = getOwnerComponentRef(t2, customController).track(t2, t)) | ||
| } | ||
|
|
||
| /* owner component ref */ |
Check warning
Code scanning / CodeQL-Community
Block comment that is not QLDoc
| module Test { | ||
| private import semmle.javascript.dataflow.TypeTracking | ||
|
|
||
| private class ObjFieldStep extends SharedTypeTrackingStep { |
Check warning
Code scanning / CodeQL-Community
Dead code
| } | ||
| } | ||
|
|
||
| private DataFlow::SourceNode objectWithMethods() { |
Check warning
Code scanning / CodeQL-Community
Dead code
| result.flowsTo(any(DataFlow::CallNode call | call.getCalleeName() = "extend").getAnArgument()) | ||
| } | ||
|
|
||
| private DataFlow::SourceNode getAnAlias(DataFlow::SourceNode object) { |
Check warning
Code scanning / CodeQL-Community
Dead code
| ) | ||
| } | ||
|
|
||
| private predicate methodStepPred(DataFlow::SourceNode object, string name, DataFlow::Node rhs) { |
Check warning
Code scanning / CodeQL-Community
Dead code
| rhs = getAnAlias(object).getAPropertyWrite(name).getRhs() | ||
| } | ||
|
|
||
| private predicate methodStepSucc(DataFlow::SourceNode object, string name, DataFlow::Node read) { |
Check warning
Code scanning / CodeQL-Community
Dead code
What This PR Contributes
Future Works