fix(client): Authentication v2: auth/login + auth/logout - #126
Merged
Conversation
EugeneTheDev
approved these changes
Sep 9, 2026
| * authentication, and the call fails locally without sending a request. | ||
| * | ||
| * The caller must select an advertised method that supports protocol-driven login. The SDK checks | ||
| * that authentication is advertised but does not validate [methodId] against the advertised list. |
Collaborator
There was a problem hiding this comment.
Why don't we validate method ids against a list of methods? Should be a simple contains check, right?
| return AcpMethod.AgentMethods.V2.AuthLogout(protocol, LogoutAuthRequest(_meta)) | ||
| } | ||
|
|
||
| private suspend fun requireAuthenticationSupport(method: String) { |
Collaborator
There was a problem hiding this comment.
nit: to avoid hardcoding auth/login and auth/logout strings, wdyt about replacing method: String with method: AcpMethod and then using AgentMethods.AuthLogin/AuthLogout?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.