Repository navigation
[Automated] Draft docs (agentgateway): llm: improvements to stream_options - #1438
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…tions Drafts-Commit: 5d034a1 Signed-off-by: GitHub Action <action@github.com>
Deploying agentproxy with
|
| Latest commit: |
13efe56
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4154bb7.agentproxy.pages.dev |
| Branch Preview URL: | https://pr-tracker-draft-agentgatewa-gws5.agentproxy.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#4156 — llm: improvements to stream_options
Docs versions:
standalone/main,standalone/latest,kubernetes/main,kubernetes/latest(first shipped in prerelease v1.7.0-rc.1)What changes for users: Chat Completions streams now include a final usage chunk before
data: [DONE], even when the client setsstream_options.include_usagetofalse. Clients that parse stream chunks must handle the final chunk withchoices: []and request-levelusage.What the docs now say: The standalone Chat Completions pages now explain the streamed usage chunk and the
stream_options.include_usageoverride. The prompt-guard and guardrail candidates do not own Chat Completions stream output, and the Kubernetes streaming page was not in the authorized target list for this run.Not verified: No cluster or standalone process was configured. The configuration is unrun.
How
agentgateway-4156was drafted, and what was not verifiedPlan, and what changed it
stream_options.include_usagebehavior on the pages named by the code-path targets for every listed tree.changed-functions.mdscope the behavior to Chat Completions streams, and the prompt-guard and guardrail candidates cover guard behavior rather than stream output.Why a documentation change is necessary
The pull request changes
process_completions_requestso that every streamed Chat Completions request setsstream_options.include_usagetotrue, including requests that explicitly set it tofalse. TheStreamOptionsdoc comment in the diff says the changed behavior adds a final usage chunk beforedata: [DONE], with an emptychoicesarray and request-levelusage. The Chat Completions page already documents response usage conventions, so readers need the streamed-response exception there.What changed on disk
content/docs/standalone/main/documentation/llm/api-types/completions.md: Added an anchored section that explains usage chunks in streamed Chat Completions replies.content/docs/standalone/latest/documentation/llm/api-types/completions.md: Added the same section for the latest tree.How to verify this change
"stream": trueand"stream_options": {"include_usage": false}.data: [DONE]withchoices: []and a populatedusageobject.usage: null.Proposed release note
Wrote
proposed-release-note.mdas a behavior-change entry for standalone/main, standalone/latest, kubernetes/main, and kubernetes/latest.What was not verified
data: [DONE],content/docs/kubernetes/main/documentation/llm/streaming.md, was not edited because the page was not in the authorized targets.How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#4156 — llm: improvements to stream_options
agentgateway/websiteA declared version this draft does not reach
This pull request is planned for more than one documentation version,
and nothing in the diff publishes to:
kubernetes/latestkubernetes/mainA file under
assets/reaches a version tree only where a page in thattree reuses it, so editing a shared asset does not by itself cover every
mode a product ships. Either that version still needs writing, or the
change genuinely does not apply there and the reason belongs in this body.
Release notes
This pull request also adds its release-note entries:
content/docs/kubernetes/latest/release-notes/release-notes.md: Chat Completions streams always include usage (breaking_change)content/docs/kubernetes/main/release-notes/release-notes.md: Chat Completions streams always include usage (breaking_change)content/docs/standalone/latest/release-notes/release-notes.md: Chat Completions streams always include usage (breaking_change)content/docs/standalone/main/release-notes/release-notes.md: Chat Completions streams always include usage (breaking_change)Check these release-note links and names. Each note is on its page, but a link may not reach the drafted content there, or a name may belong to the other mode:
content/docs/kubernetes/latest/release-notes/release-notes.md: llm: improvements to stream_options agentgateway#4156's note namesstream_options.include_usage, whichcontent/docs/standalone/latestmentions andcontent/docs/kubernetes/latestdoes not. Check that this tree's readers can set it, or word the note for this mode.content/docs/kubernetes/main/release-notes/release-notes.md: llm: improvements to stream_options agentgateway#4156's note namesstream_options.include_usage, whichcontent/docs/standalone/mainmentions andcontent/docs/kubernetes/maindoes not. Check that this tree's readers can set it, or word the note for this mode.content/docs/standalone/latest/release-notes/release-notes.md: llm: improvements to stream_options agentgateway#4156's note names. Update stream parsers that assumed streamed chunks before, whichcontent/docs/kubernetes/latestmentions andcontent/docs/standalone/latestdoes not. Check that this tree's readers can set it, or word the note for this mode.content/docs/standalone/main/release-notes/release-notes.md: llm: improvements to stream_options agentgateway#4156's note names. Update stream parsers that assumed streamed chunks before, whichcontent/docs/kubernetes/mainmentions andcontent/docs/standalone/maindoes not. Check that this tree's readers can set it, or word the note for this mode.Draft branch:
pr-tracker-draft-agentgateway-4156