🔧 ci: fix CI rot - #117
Merged
Merged
Conversation
No file changes. Purpose is to run CI on a fresh branch off `upstream/master` so the resulting failures (pre-commit `pretty-format-toml`/`yaml`, `mypy` unused-ignore in `launch.py`, RabbitMQ-backed daemon tests) can be confirmed as pre-existing CI rot rather than regressions from any feature work. Follow-up commits on this branch will address each in turn.
Three independent CI failures appeared on this branch, all caused by upstream dep drift rather than any code change here. Bundle the fixes: - `.github/workflows/ci.yml`: pin `rabbitmq:latest` → `rabbitmq:3.8.14-management`. RabbitMQ 4.x rejects transient non-exclusive queues by default, which broke 5 daemon-backed tests here. Matches the pin `aiida-core` uses in its own `ci-code.yml`/`test-install.yml`. - `.pre-commit-config.yaml`: bump `language-formatters-pre-commit-hooks` v2.11.0 → v2.16.0. The v2.11.0 hook imports `pkg_resources`; modern Python venvs no longer ship `setuptools` by default, so `pretty-format-toml` and `pretty-format-yaml` fail with `ModuleNotFoundError`. v2.14.0 dropped the `pkg_resources` import. - `src/aiida_shell/launch.py`: drop the dead `# type: ignore[assignment]` on the `code = ShellCode(...).store()` line. Newer mypy type-checks the assignment cleanly, so the comment was failing the `mypy` pre-commit hook as `unused-ignore` under `strict = true`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by occuring unrelated CI failures on #116.
Appearing here after empty commit
54506ef:Will squash-merge to obliterate the initial empty commit once approved 💥