fix error if you have a popup window selected the first time you open the terminal#662
Open
apple1417 wants to merge 1 commit intoakinsho:mainfrom
Open
fix error if you have a popup window selected the first time you open the terminal#662apple1417 wants to merge 1 commit intoakinsho:mainfrom
apple1417 wants to merge 1 commit intoakinsho:mainfrom
Conversation
… the terminal fixes akinsho#660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #660 - see my comment for a full description of the error path
I'm not familiar enough with the codebase to know if this is the best possible fix, but it does at least work. My thinking was these functions probably meant "if we have a window, double check if it's floating" - hence only bothering checking
ui.is_floatif we have one.