Reusable Workflows for building and deployment - #2
Merged
Merged
Conversation
i2b2 docker and debian build.sh now integrate the downloads fo i2b2 files. BREAKING CHANGE: reusable workflow input "download-i2b2" removed
Both passphrase and private key authentication were implemented but only private key authentication will be used.
For consistency we use the same term as AKTIN debian build.sh which use "PACKAGE_NAME". BREAKING CHANGE: reusable workflow input "name-base" renamed to "package-name"
This was referenced Dec 18, 2024
The build.sh now retrieves the version from a versions file instead of from script parameter.
The debian testing will be handled in the repositories of the debian packages.
The versions file now contains comments which use # as first character of the line.
… tag The build.sh now retrieves the version from a versions file instead of from script parameter. This version contains ~ to indicate unstable releases as per debian versioning guidelines. The ~ are not contained in the git tag, which are the previous source of the version.
… preparation With the new way of retrieving the versions (from version files instead for git tag) checkout needs to happen prior to version preparation.
…on-deployment cases
akomii
requested changes
Jan 22, 2025
Having the path to the repository (formerly REPREPRO_HOME) as an input is more generic.
…t dependencies Make workflow more generic. BREAKING CHANGE: removes reusable workflow input "install-r"
Allows the keep the hostname of the maven repository confidential. Note: It requires that the "MAVEN_REPOSITORY" environment variable is used as value of the distributionManagement/repository/id field of the pom.xml, or it will have no effect.
…HOME Accidentally not removed in 909c018.
…gent BREAKING CHANGE: adds required secrets "GPG_PASSPHRASE" and "GPG_KEYGRIP"
Contributor
Author
|
We should have a discussion about how the versions of projects and their modules are intended to relate to each other. I think there is some potential for simplifying the poms, which could give some quality of life improvements even without applying CI friendly versions. Also, I noticed that I misapplied the use of CI friendly version placeholders with regard to the aktin pom and its child poms because of the odd relationship between the projects. The corresponding pull requests have been marked as draft: aktin/aktin#4, aktin/dwh-admin#18, aktin/dwh-api#1, aktin/dwh-db#4, aktin/dwh-import#7, aktin/dwh-j2ee#4, aktin/dwh-prefs#6, aktin/dwh-query#12, aktin/dwh-setup#1, aktin/r-script#2 |
akomii
reviewed
Jan 28, 2025
More consistent look.
akomii
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusable Workflows for building and deploying AKTIN maven projects, debian packages, and docker images.