Skip to content

Strict HTML4 and blank by default#2

Open
racitup wants to merge 18 commits intoalexmalykh:masterfrom
racitup:html4-blank
Open

Strict HTML4 and blank by default#2
racitup wants to merge 18 commits intoalexmalykh:masterfrom
racitup:html4-blank

Conversation

@racitup
Copy link
Copy Markdown

@racitup racitup commented Oct 11, 2016

I've had a rethink about this and decided the original method of wrapping a placeholder is more flexible. However I have made some useful enhancements.

I have only tested on my python 3.5.2 django 1.9.9 environment.

@alexmalykh
Copy link
Copy Markdown
Owner

alexmalykh commented Oct 12, 2016

Actually, the plugin package is intended to be lightweight and to have as less dependencies as possible. So I've dropped six and don't use sekizai tags in the plugin template explicitly (despite sekizai is pulled by CMS itself), but I mentioned possible way to engage it in readme file. Grab updates from master branch, please.

@alexmalykh
Copy link
Copy Markdown
Owner

Please also note, that fields defaults are chosen that they reflect ones defined in W3 CSS spec. This is intentional.

@racitup
Copy link
Copy Markdown
Author

racitup commented Oct 12, 2016

Hi Alex,
Great plugin by the way!

Well I don't think you gain anything by not using sekizai since as you say it is already required by the CMS. Plus having inline style tags is not valid HTML4 - CSS must go in the head section.

Also the main use of this plugin will be to override styles already defined in included CSS, that's why the tag should be blank by default.

Hope that makes sense!

@alexmalykh
Copy link
Copy Markdown
Owner

alexmalykh commented Oct 14, 2016

Hi Richard, I've incorporated most of the patch you submitted. I think, after some testing there will be a new release in October. Thanks for contributing :)

@racitup
Copy link
Copy Markdown
Author

racitup commented Oct 14, 2016

Hi Alex, no worries. I'll have a merge and see where we are. Yes forgot CSS has an inherit option, not specified makes more sense.

@alexmalykh
Copy link
Copy Markdown
Owner

Oops, my fault, missed that paragraph about enforced sekizai namespaces :)
Have reverted corresponding commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants