fix(rocklet): skip bash installation when already present in musl containers#1207
Open
zhangjaycee wants to merge 1 commit into
Open
fix(rocklet): skip bash installation when already present in musl containers#1207zhangjaycee wants to merge 1 commit into
zhangjaycee wants to merge 1 commit into
Conversation
…tainers On customized Alpine images with a corrupted APK database, `apk add bash` returns a non-zero exit code even though bash is already installed. Combined with `set -o errexit`, this causes docker_run.sh to exit before installing the glibc compatibility layer or starting rocklet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1206
On customized Alpine images with a corrupted APK database,
apk add bashreturns a non-zero exit code even though bash is already installed. Combined withset -o errexit, this causes docker_run.sh to exit before installing the glibc compatibility layer or starting rocklet.