Open
Conversation
Author
|
PTAL @ChuanqiXu9 @poor-circle |
ChuanqiXu9
approved these changes
Feb 26, 2026
Collaborator
ChuanqiXu9
left a comment
There was a problem hiding this comment.
LGTM. Will merge after CI gets green
Author
Thanks for the review!
I believe the related CI is now passing for macos bazel build and test, as well as linux bazel build (except for one test failure that I cannot reproduce on my own x86 machine). While some CI are already failing in the main branch, I am willing to investigate and address them in subsequent patches for better clarity and coherence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Current bazel build not work out of the box.
What is changing