Skip to content

Regenerate CLI from latest OAS - #13

Open
carlostasada wants to merge 2 commits into
mainfrom
ctasada/regenerate-latest-oas
Open

Regenerate CLI from latest OAS#13
carlostasada wants to merge 2 commits into
mainfrom
ctasada/regenerate-latest-oas

Conversation

@carlostasada

Copy link
Copy Markdown
Contributor

Summary

  • Sync OpenAPI specs and regenerate CLI clients, commands, and metadata
  • Remove market-data commands no longer present upstream (data index, data fixed-income)
  • Adapt order submit hook to CreateOrderRequest body rename
  • Pick up new flags (--order-id on account activity, --data-quality on corporate-actions)
  • Refresh docs, goldens, and integration coverage

Test plan

  • make check
  • make test-integration — suite passes except TestPositionCloseAll / TestPositionCloseAll_CancelOrders (paper account returns 403 closing leftover equity positions; unrelated to this regenerate)

Sync OpenAPI specs and regenerate clients, commands, and metadata.
Drop removed market-data index and fixed-income commands, and update
order submit for the CreateOrderRequest body rename.
@carlostasada carlostasada self-assigned this Aug 5, 2026
@carlostasada
carlostasada requested a review from sachyco August 5, 2026 09:55
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

The PR synchronizes the OpenAPI specifications and regenerated CLI artifacts, restructures fixed-income market-data commands, removes index commands, and updates trading request models.

  • Adds OAS 3.1 nullable-type handling to the generator.
  • Regenerates trading and market-data clients, types, command metadata, and golden files.
  • Adds account-activity and corporate-action flags and updates order submission for CreateOrderRequest.
  • Removes obsolete index integration coverage and reorganizes fixed-income commands.

Confidence Score: 5/5

The PR appears safe to merge based on the eligible follow-up findings.

No blocking failure remains in the eligible review scope.

Important Files Changed

Filename Overview
cmd/generate/main.go Adds OAS 3.1 nullable-type parsing and applies it across generated type and flag resolution.
cmd/generate/commands.go Reorganizes fixed-income commands, removes index command registrations, and updates generated schema classification.
internal/cmd/order.go Adapts the order submission hook to the newly named generated request body type.
internal/cmd/commands.gen.go Refreshes the generated command tree and exposes the newly imported flags and endpoints.
internal/api/trading_types.gen.go Regenerates trading API models from the updated specification.
internal/api/marketdata_types.gen.go Regenerates market-data models, including corporate-action data-quality support and removal of index models.
README.md Refreshes the documented market-data command areas.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  OAS[Updated OpenAPI specifications] --> Generator[CLI generator]
  Generator --> Clients[Generated API clients and types]
  Generator --> Commands[Generated command metadata]
  Commands --> CLI[Alpaca CLI command tree]
  Clients --> Runtime[API request and response handling]
  CLI --> Runtime
Loading

Reviews (2): Last reviewed commit: "Regenerate CLI from latest OAS" | Re-trigger Greptile

@carlostasada
carlostasada marked this pull request as draft August 5, 2026 14:27
Add data fixed-income latest-prices/quotes and teach the generator OAS 3.1
nullable type arrays so request bodies keep working.
@carlostasada
carlostasada marked this pull request as ready for review August 11, 2026 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant