Skip to content

feat/bulk-create-billing-group-uri-and-vendor#834

Merged
flowerinthenight merged 7 commits intomainfrom
feat/bulk-create-billing-group-uri-and-vendor
Mar 17, 2026
Merged

feat/bulk-create-billing-group-uri-and-vendor#834
flowerinthenight merged 7 commits intomainfrom
feat/bulk-create-billing-group-uri-and-vendor

Conversation

@markkeshian
Copy link
Copy Markdown
Contributor

No description provided.

@markkeshian markkeshian requested a review from tituscarl March 13, 2026 08:00
@tituscarl
Copy link
Copy Markdown
Collaborator

tituscarl commented Mar 16, 2026

@markkeshian will you also convert the bulkcreate to async?

tituscarl
tituscarl previously approved these changes Mar 16, 2026
@tituscarl
Copy link
Copy Markdown
Collaborator

@flowerinthenight if you have time, can you please also check? Thanks

@flowerinthenight
Copy link
Copy Markdown
Contributor

If this is converted to async, should use long-running ops.

@tituscarl
Copy link
Copy Markdown
Collaborator

If this is converted to async, should use long-running ops.

Do we need to call the LongOps' GetOps API directly from UI or can just wrap it in another RPC like for example in this case:
GetBulkCreateBillingGroupJob

@markkeshian
Copy link
Copy Markdown
Contributor Author

i made it like the ExportCostFiltersFile now

@flowerinthenight
Copy link
Copy Markdown
Contributor

If this is converted to async, should use long-running ops.

Do we need to call the LongOps' GetOps API directly from UI or can just wrap it in another RPC like for example in this case: GetBulkCreateBillingGroupJob

@tituscarl Not sure I got you. Do you mean https://labs.alphaus.cloud/blueapidocs/#/Operations/Operations_GetOperation is not callable from UI? Or the output proto is difficult to parse in UI?

@tituscarl
Copy link
Copy Markdown
Collaborator

@flowerinthenight Ah no, just asking for uniformity across API that uses LongOps.

Copy link
Copy Markdown
Collaborator

@tituscarl tituscarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flowerinthenight If you have time, can you please check?

@flowerinthenight flowerinthenight merged commit c6bc857 into main Mar 17, 2026
2 checks passed
@flowerinthenight flowerinthenight deleted the feat/bulk-create-billing-group-uri-and-vendor branch March 17, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants