Skip to content

change to get method for listforecast#841

Closed
ninyolittle wants to merge 1 commit intomainfrom
recommendation
Closed

change to get method for listforecast#841
ninyolittle wants to merge 1 commit intomainfrom
recommendation

Conversation

@ninyolittle
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@tituscarl tituscarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ninyolittle since you're going to modify this, can you also check the link below? this is for consistency across blueapi methods.
https://internal-docs-dev.alphaus.cloud/blue-api/#methods

@ninyolittle
Copy link
Copy Markdown
Contributor Author

thanks, @tituscarl. I wasn’t aware that we already have a specific guidelines for defining endpoints. I’ll close this PR for now since it’s not a priority at the moment.
I changed this to GET because of RBAC. I’ve been mapping endpoints along with their HTTP methods to the corresponding permissions, and I noticed that this endpoint uses POST even though it behaves like a List operation.
I’ll take this into account and follow these guidelines for future API endpoint designs.

@ninyolittle ninyolittle deleted the recommendation branch March 24, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants