Jaspal packageplugin tech support changes#71
Merged
Conversation
jaspals3123
requested review from
alexandraBara and
landrews-amd
as code owners
December 3, 2025 17:38
alexandraBara
requested changes
Dec 3, 2025
alexandraBara
left a comment
Collaborator
There was a problem hiding this comment.
Please add functional test, or update existing if there and also add utest for the new functions/functionality you have added.
alexandraBara
requested changes
Dec 4, 2025
| self.result.status = ExecutionStatus.OK | ||
| self._log_event( | ||
| category=EventCategory.OS, | ||
| description=f"Found {len(rocm_packages)} ROCm-related packages installed as per given regex: {rocm_pattern}", |
Collaborator
There was a problem hiding this comment.
Suggested change
| description=f"Found {len(rocm_packages)} ROCm-related packages installed as per given regex: {rocm_pattern}", | |
| description=f"Found {len(rocm_packages)} ROCm-related packages installed.", |
Leave the regex out since it will be printed as part of the data
alexandraBara
approved these changes
Dec 8, 2025
alexandraBara
approved these changes
Dec 8, 2025
jaspals3123
force-pushed
the
jaspal_packageplugin
branch
from
December 9, 2025 00:29
716fd1a to
868f1bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support in PackagePlugin to filter rocm packages with regex like:
'ocl-icd|kfdtest|llvm-amd|miopen|half|^ii hip|hcc|hsa|rocm|atmi|^ii comgr|composa|amd-smi|aomp|amdgpu|rock|mivision|migraph|rocprofiler|roctracer|rocbl|hipify|rocsol|rocthr|rocff|rocalu|rocprim|rocrand|rccl|rocspar|rdc|rocwmma|rpp|openmp|amdfwflash|ocl|opencl'Before:
After:
Test with the plugin_config.json:
Run:
node-scraper --plugin-config plugin_config.json