add card2pmml method to export a scorecard to pmml#124
Closed
itlubber wants to merge 6 commits intoamphibian-dev:masterfrom
Closed
add card2pmml method to export a scorecard to pmml#124itlubber wants to merge 6 commits intoamphibian-dev:masterfrom
itlubber wants to merge 6 commits intoamphibian-dev:masterfrom
Conversation
Member
|
Thanks for the idea of adding PMML export! This is a useful feature for production deployment scenarios. However, the current implementation has some issues that need to be addressed before merging:
Could you consider:
Happy to help review a refreshed version! |
Secbone
added a commit
that referenced
this pull request
Apr 14, 2026
Add ScoreCard.card2pmml() method to export scorecard rules to PMML format, enabling deployment in Java/PMML ecosystems. This addresses the feature request from PR #124 with a cleaner implementation. Changes: - Add _build_numeric_expression() helper for ExpressionTransformer - Add card2pmml() method using sklearn2pmml pipeline - Add requirements-pmml.txt with sklearn2pmml/sklearn-pandas deps - Add [pmml] optional dependency group in pyproject.toml - Add comprehensive unit tests and integration tests (with skip guards) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Secbone
approved these changes
Apr 14, 2026
Secbone
added a commit
that referenced
this pull request
Apr 14, 2026
* feat: add card2pmml() for PMML export of scorecards Add ScoreCard.card2pmml() method to export scorecard rules to PMML format, enabling deployment in Java/PMML ecosystems. This addresses the feature request from PR #124 with a cleaner implementation. Changes: - Add _build_numeric_expression() helper for ExpressionTransformer - Add card2pmml() method using sklearn2pmml pipeline - Add requirements-pmml.txt with sklearn2pmml/sklearn-pandas deps - Add [pmml] optional dependency group in pyproject.toml - Add comprehensive unit tests and integration tests (with skip guards) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: check rules before imports in card2pmml Move the empty-rules guard before the lazy import block so test_card2pmml_missing_rules works even when sklearn2pmml is not installed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add card2pmml method to export a scorecard to pmml