Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sqlparse/filters/others.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,15 @@ def _stripws_identifierlist(self, tlist):
return self._stripws_default(tlist)

def _stripws_parenthesis(self, tlist):
while tlist.tokens[1].is_whitespace:
# Short groups (e.g. "(::)") lack open/body/close slots for inner ws pops.
while len(tlist.tokens) > 2 and tlist.tokens[1].is_whitespace:
tlist.tokens.pop(1)
while tlist.tokens[-2].is_whitespace:
while len(tlist.tokens) > 2 and tlist.tokens[-2].is_whitespace:
tlist.tokens.pop(-2)
if tlist.tokens[-2].is_group:
if len(tlist.tokens) > 2 and tlist.tokens[-2].is_group:
# save to remove the last whitespace
while tlist.tokens[-2].tokens[-1].is_whitespace:
while (tlist.tokens[-2].tokens
and tlist.tokens[-2].tokens[-1].is_whitespace):
tlist.tokens[-2].tokens.pop(-1)
self._stripws_default(tlist)

Expand Down
3 changes: 3 additions & 0 deletions tests/test_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,9 @@ def test_parenthesis(self):
assert f("select f(\n\n\n1\n\n\n)") == 'select f(1)'
assert f("select f(\n\n\n 1 \n\n\n)") == 'select f(1)'
assert f("select f(\n\n\n 1 \n\n\n)") == 'select f(1)'
# Cast-like "(::)" is one Identifier inside Parenthesis; must not IndexError
assert f('(::)') == '(::)'
assert f('()') == '()'

def test_where(self):
f = lambda sql: sqlparse.format(sql, reindent=True)
Expand Down