-
Notifications
You must be signed in to change notification settings - Fork 5
[FEATURE] Make allowed file extensions configurable for all file processors #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Make allowed file extensions configurable for all file processors #343
Conversation
|
I've implemented Unit Tests for the 4 FileProcessors to validate either the default or custom configuration of allowed file extension work accordingly. |
|
Just 4yi: I'm focusing first on the tasks that are relevant for my budget as promised an will then take care about all the other things. |
|
It's totally fine, I fully understand. No need to rush. We've created a Fractor-Extension with those adjustments, ready to be superceded by the main project once it's there. |
|
If you want to get some feedback, you can also reach out to Andreas on Slack or here. |
simonschaufi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is missing is the documentation part in the readme.
95f7889 to
bd79a9c
Compare
bd79a9c to
8df7cea
Compare
…ions 📝 Added a section on configuring allowed file extensions for different processors. 🔧 Provided default extensions for Fluid, TypoScript, XML, and YAML file types.
I've added the section in 849b1e4 |
|
Please let me know if there is anything else missing or to be done. |
|
Thank you very much for your contribution! |
|
Very much welcomed 😁 |
Make allowed file extensions configurable for all file processors
Description
This pull request addresses the issue #337 "Feature Request: Make allowed file extensions configurable". By introducing configurable allowed file extensions, users can now customize which file extensions each processor handles without modifying source code.
The previous defined, hardcoded file extensions serve as default values, but can now be customized to the user's extend.
Changes
Fluid Processor
FluidProcessorOptionwithALLOWED_FILE_EXTENSIONSconstantFluidFormatConfigurationclassFluidFileProcessorto read from configurationTypoScript Processor
ALLOWED_FILE_EXTENSIONSconstant toTypoScriptProcessorOptionTypoScriptPrettyPrinterFormatConfigurationto accept and manage allowed file extensionsTypoScriptFileProcessorto use strict comparison and read from configurationYaml Processor
YamlProcessorOptionwithALLOWED_FILE_EXTENSIONSconstantYamlFormatConfigurationclass for managing allowed extensionsYamlFileProcessorto use the new configuration classXml Processor
ALLOWED_FILE_EXTENSIONSconstant toXmlProcessorOptionXmlFormatConfigurationclassXmlFileProcessorto use configuration and strict comparisonCommits
[FEATURE] Introduce FluidFormatConfiguration and update FluidFileProcessor- Adds configuration for Fluid processor[FEATURE] Add XmlFormatConfiguration and integrate into XmlFileProcessor- Adds configuration for Xml processor[FEATURE] Implement YamlFormatConfiguration and integrate into YamlFileProcessor- Adds configuration for Yaml processor[FEATURE] Enhance TypoScript configuration options- Adds configuration for TypoScript processorVerification
To verify the changes:
composer local:contributeto ensure all code quality checks passExample
A simplified example configuration regarding the new configuration options might look like the following: