Skip to content

Add cookieSecure and cookieSameSite config options #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edclements wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add cookieSecure and cookieSameSite config options #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,8 @@ ahoy.configure({
trackVisits: true,
cookies: true,
cookieDomain: null,
cookieSecure: false,
cookieSameSite: "lax",
headers: {},
visitParams: {},
withCredentials: false,
Expand Down
8 changes: 6 additions & 2 deletions src/cookies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
// https://www.quirksmode.org/js/cookies.html

export default {
set: function (name, value, ttl, domain) {
set: function (name, value, ttl, domain, secure, sameSite) {
let expires = "";
let cookieDomain = "";
let cookieSecure = "";
if (ttl) {
const date = new Date();
date.setTime(date.getTime() + (ttl * 60 * 1000));
Expand All @@ -12,7 +13,10 @@ export default {
if (domain) {
cookieDomain = "; domain=" + domain;
}
document.cookie = name + "=" + escape(value) + expires + cookieDomain + "; path=/; samesite=lax";
if (secure) {
cookieSecure = "; secure";
}
document.cookie = name + "=" + escape(value) + expires + cookieDomain + "; path=/; samesite=" + (sameSite || "lax") + cookieSecure;
},
get: function (name) {
let i, c;
Expand Down
6 changes: 4 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const config = {
trackVisits: true,
cookies: true,
cookieDomain: null,
cookieSecure: false,
cookieSameSite: "lax",
headers: {},
visitParams: {},
withCredentials: false,
Expand Down Expand Up @@ -67,15 +69,15 @@ function serialize(object) {
// cookies

function setCookie(name, value, ttl) {
Cookies.set(name, value, ttl, config.cookieDomain || config.domain);
Cookies.set(name, value, ttl, config.cookieDomain || config.domain, config.cookieSecure, config.cookieSameSite);
}

function getCookie(name) {
return Cookies.get(name);
}

function destroyCookie(name) {
Cookies.set(name, "", -1, config.cookieDomain || config.domain);
Cookies.set(name, "", -1, config.cookieDomain || config.domain, config.cookieSecure, config.cookieSameSite);
}

function log(message) {
Expand Down