call onScroll event on failed attempt to scroll down#349
Closed
rahulakrishna wants to merge 1 commit intoankeetmaini:masterfrom
Closed
call onScroll event on failed attempt to scroll down#349rahulakrishna wants to merge 1 commit intoankeetmaini:masterfrom
rahulakrishna wants to merge 1 commit intoankeetmaini:masterfrom
Conversation
Resolves: loader doesn't appear when page is bigger than InfiniteScroll ankeetmaini#345
Author
|
@ankeetmaini can we merge this? |
|
+1 |
Collaborator
|
Thanks for the contribution. This addresses the same "content doesn't fill the viewport" problem as #381, but via a wheel event listener workaround. The v7.0.0 rewrite handles this naturally through the IntersectionObserver sentinel, which stays visible and keeps triggering If you'd like to keep contributing, check out the open issues or file a new one if you find something worth fixing. Looking forward to more contributions from you, let's make this the best infinite scroll library out there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to Test
src/stories/WindowInfiniteScrollComponent.tsx, change the Array length to a lower number.Resolves: loader doesn't appear when page is bigger than InfiniteScroll #345