change a regex and contents on Redirect on login chapter#285
Open
pobch wants to merge 2 commits intoanomalyco:masterfrom
Open
change a regex and contents on Redirect on login chapter#285pobch wants to merge 2 commits intoanomalyco:masterfrom
pobch wants to merge 2 commits intoanomalyco:masterfrom
Conversation
Contributor
|
Thanks for simplifying the regex.
Not sure I follow what you mean here. I don't see the change that you made? |
Contributor
Author
I added the content on line 55 |
Contributor
|
Got it. Thanks. I'll merge this after I make this change in the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queryString()with"redirect"as an argument, so I think it's not necessary to use regex to escape special characters onnamevariable. (and you forgot to put regex special characters in the braces)=toresults[2], so it's not necessary to capture&or#or$toresults[1].window.location.hrefis encoded byencodeURI(), notencodeURIComponent. So, we should usedecodeURIto decode it.Signupcomponent withUnauthenticatedRoutewhich takes responsibility for redirecting. So we should remove a redirecting logic inSignupto prevent conflicts.