fix(drive): render screenshots locally - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make Drive own screenshot rendering. OpenCode now exposes terminal frame capture over the simulation bridge, while
opencode-driveconverts that frame to PNG and writes it into the active instance generation's media directory.Before / After
Before:
ui.screenshotcrossed the simulation RPC boundary, so OpenCode's simulation package had to carry Canvas, fonts, and PNG rendering code. That coupled production OpenCode artifacts to Drive-only capture behavior.After: Drive sends
ui.capture, renders the returned RGBA frame locally, and writes the PNG itself. Named, visible, direct-endpoint, scripted, and restarted instances all resolve screenshots to the correct media generation.How
ui.screenshotfrom Drive's embedded OpenCode simulation protocol and keeps it as a Drive-level command.Scope
latest,next, exact versions/tags, and--dev) remains separate work.Testing
bun run checkbun run testbun run release:validateFlow