fix(mcp): reconnect after OAuth even when server is disabled#33920
Open
MaxAnderson95 wants to merge 1 commit into
Open
fix(mcp): reconnect after OAuth even when server is disabled#33920MaxAnderson95 wants to merge 1 commit into
MaxAnderson95 wants to merge 1 commit into
Conversation
finishAuth passed the raw config to createAndStore, so a server with enabled: false short-circuited in create() and returned status "disabled" right after a successful OAuth flow. Force enabled: true the same way connect() already does so the server actually connects. Closes anomalyco#33915 OpenCode session ID: ses_100f47509ffeVOfeYfrub3HYwF
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33915
Type of change
What does this PR do?
opencode mcp auth <name>prints "Unexpected status: disabled" after a successful OAuth flow when the server is set to"enabled": falsein the config. The token saves fine, but the server never connects and it looks like auth failed.finishAuthwas passing the raw config tocreateAndStore, soenabled: falsemadecreate()short-circuit and returndisabled.connect()already handles this by forcingenabled: truebefore reconnecting — this does the same infinishAuth.Same fix as #20279, which was closed before it got merged.
How did you verify your code works?
Added a remote OAuth MCP server with
"enabled": false, ranbun dev mcp auth <name>, and completed the browser flow. It now prints "Authentication successful!" and the server connects. The same steps before the change gave "Unexpected status: disabled".Screenshots / recordings
N/A — CLI output change only.
Checklist