fix(cli): mark lightningcss as external in the compiled build - #42526
Open
moedash wants to merge 1 commit into
Open
fix(cli): mark lightningcss as external in the compiled build#42526moedash wants to merge 1 commit into
moedash wants to merge 1 commit into
Conversation
lightningcss (via ui and tailwind) has a conditional native-binding require the bundler cannot resolve; the TUI never runs that path, so it stays external.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42525
Type of change
What does this PR do?
bun run --cwd packages/cli build --singlefails from a fresh clone:lightningcsscomes in via@opencode-ai/ui-> tailwind. Itsnode/index.jshas a conditionalrequire("../pkg")for the wasm variant, andBun.buildtries to resolve that path even though the branch never runs. Markinglightningcssexternal skips the resolution. It is safe because nothing in the TUI calls lightningcss at runtime; if something ever did, the require would fail loudly instead of silently bundling wrong.Seen with bun 1.3.14 on macOS arm64. Your release CI presumably builds under a configuration where this doesn't trigger, but a fresh local clone hits it every time.
How did you verify your code works?
Before the change: the build fails with the error above, repeatably. After: the build completes and I exercised the compiled binary end to end: TUI boot, daemon spawn via
serve --register, sessions served over the API.Screenshots / recordings
Not a UI change.
Checklist