Make the "Toggle Source" log display only hide source fields, not all fields#55474
Merged
ashb merged 1 commit intoapache:mainfrom Sep 10, 2025
Merged
Conversation
ashb
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
kaxil
approved these changes
Sep 10, 2025
jscheffl
approved these changes
Sep 10, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Cool! Just nit in test to be fixed. Else I liek very much!
… fields With the move to structured logging wholesale in apache#52651, we are going to start seeing a lot more structured log key/values other than just `logger` and `chan` -- so "Toggle Source" now just hides those specific fields. It also changes the format/display to cope better with more than one KV being shown in the logs.
ashb
force-pushed
the
log-toggle-source-keep-other-struct-fields
branch
from
cc3416e to
73bbe12
Compare
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 11, 2025
… fields (apache#55474) (cherry picked from commit 224b50c)
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
Brunda10
pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the move to structured logging wholesale in #52651, we are going to start
seeing a lot more structured log key/values other than just
loggerandchan-- so "Toggle Source" now just hides those specific fields.It also changes the format/display to cope better with more than one KV being shown
in the logs.
Before, with Source
Before, without Source
After, with Source
After, without Source
Note the
filename=andlineno=in a few places -- those are other key/value pairs from log lines like this (that I am working on as part of another change:{ "timestamp":"2025-09-10T15:44:46.734893", "level":"info", "event":"Done. Returned value was: None", "logger":"airflow.task.operators.airflow.providers.standard.operators.python.PythonOperator", "filename":"python.py", "lineno":218 }^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.