Skip to content

Fix XCom slice endpoint returning wrong rows for crossed-bound slices#69205

Open
dhruv-techdev wants to merge 2 commits into
apache:mainfrom
dhruv-techdev:fix/xcom-slice-crossed-bounds
Open

Fix XCom slice endpoint returning wrong rows for crossed-bound slices#69205
dhruv-techdev wants to merge 2 commits into
apache:mainfrom
dhruv-techdev:fix/xcom-slice-crossed-bounds

Conversation

@dhruv-techdev

@dhruv-techdev dhruv-techdev commented Jul 1, 2026

Copy link
Copy Markdown

A crossed-bound sequence slice (stop before start) evaluates to an empty list in Python, but the mapped-XCom slice endpoint translated it into a SQLAlchemy .slice() with a negative SQL LIMIT. On SQLite a negative LIMIT means "no limit", so rows were silently returned from the offset onward; on PostgreSQL/MySQL the negative LIMIT is rejected and the request fails. Return an empty result for crossed bounds so behaviour matches Python slicing on every backend.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:task-sdk labels Jul 1, 2026
@boring-cyborg

boring-cyborg Bot commented Jul 1, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

A crossed-bound sequence slice (stop before start) evaluates to an empty list in Python, but the mapped-XCom slice endpoint translated it into a SQLAlchemy .slice() with a negative SQL LIMIT. On SQLite a negative LIMIT means "no limit", so rows were silently returned from the offset onward; on PostgreSQL/MySQL the negative LIMIT is rejected and the request fails. Return an empty result for crossed bounds so behaviour matches Python slicing on every backend.
@dhruv-techdev dhruv-techdev force-pushed the fix/xcom-slice-crossed-bounds branch from 7ecd72f to 29f39d0 Compare July 1, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:task-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant