Allow slashes in connection IDs fetched via the Execution API#69228
Draft
justinpakzad wants to merge 1 commit into
Draft
Allow slashes in connection IDs fetched via the Execution API#69228justinpakzad wants to merge 1 commit into
justinpakzad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a path converter to the
get_connectionroute in the Execution API so that connections whose IDs contain forward slashes can be fetched. Currently, the endpoint returns a 404 when fetching a connection with an ID such asdev/my_conn. This fix is mainly applicable for secrets backends, as connections created via the REST API/CLI do not allow slashes in theconn_id(although the Connection model itself does). An additional test case was added to cover the new behavior.closes: #57864
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.