Repository navigation
Fix Edge workers not reporting the final state of deadline callbacks - #74784
Merged
Merged
Conversation
FrankYang0529
force-pushed
the
fix-edge3-callback-log-push
branch
from
October 16, 2026 03:24
678a65a to
b43c75e
Compare
FrankYang0529
marked this pull request as ready for review
October 16, 2026 06:31
FrankYang0529
requested review from
dheerajturaga,
jscheffl and
shubhamraj-git
as code owners
October 16, 2026 06:31
Lee-W
approved these changes
Oct 22, 2026
Lee-W
reviewed
Oct 22, 2026
Lee-W
reviewed
Oct 22, 2026
Signed-off-by: PoAn Yang <payang@apache.org>
Co-authored-by: Wei Lee <hello@wei-lee.me>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
fix-edge3-callback-log-push
branch
from
October 22, 2026 04:40
dfcf3e7 to
af38628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SyncCallbackof a Deadline Alert, on Edge workers. With the default[edge] push_logs = True, the worker never reports whether the callback succeeded or failed.dag_id="ExecuteCallback". The log route on the API server looks up a task instance for that key. No such task instance exists, so the route fails with HTTP 500. Even a callback whose code logs nothing leaves a non-empty log file, so the push fails for every callback.How
log_pathfrom the workload JSON that the scheduler stored in thecommandcolumn of theedge_jobrow. The worker reads the callback log from that same relative path. For a callback whose row orlog_pathis missing, both log routes return 404 instead of 500.Was generative AI tooling used to co-author this PR?