Repository navigation
Go SDK: Write the edge label text before the task - #75185
Merged
Merged
Conversation
FrankYang0529
marked this pull request as ready for review
October 20, 2026 06:05
FrankYang0529
requested review from
amoghrajesh,
ashb and
jason810496
as code owners
October 20, 2026 06:05
1 task done
jason810496
reviewed
Oct 21, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the cleanup, LGTM overall, here're some findings by the agent review.
Signed-off-by: PoAn Yang <payang@apache.org>
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
go-sdk-label-syntax
branch
from
October 21, 2026 15:10
96ba0e8 to
478077b
Compare
jason810496
approved these changes
Oct 22, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Thanks for the update, LGTM overall.
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 22, 2026
…#75185) * Go SDK: Write the edge label text before the task Signed-off-by: PoAn Yang <payang@apache.org> * Go SDK: Reject labels with no edge and name nil task positions Signed-off-by: PoAn Yang <payang@apache.org> --------- (cherry picked from commit 70b95a2) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 22, 2026
…#75185) * Go SDK: Write the edge label text before the task Signed-off-by: PoAn Yang <payang@apache.org> * Go SDK: Reject labels with no edge and name nil task positions Signed-off-by: PoAn Yang <payang@apache.org> --------- (cherry picked from commit 70b95a2) Co-authored-by: PoAn Yang <payang@apache.org> Signed-off-by: PoAn Yang <payang@apache.org>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change label form from
airflow.Label(node, text)toairflow.Label(text).On(node)as Java SDK's edge labels (#74523).airflow.Label(text)returns a*airflow.LabelRef.(*LabelRef).On(node, more...)returns theNodeto pass toBeforeorAfter. The signature ofOnrequires at least one node, so the compiler rejects a call with none. WhenOngets several nodes, the edges to all of them get the same label, as in Python'sa >> Label("forks") >> [b, c].airflow.Labelnow panics on text that is only white space, not only on empty text.BeforeandAfternow panic when their receiver carries a label.Was generative AI tooling used to co-author this PR?