-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(parquet): add ParquetPushDecoder::peek_next_row_group() #10158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
390ddc8
feat(parquet): add ParquetPushDecoder::peek_next_row_group()
zhuqi-lucas 739d94e
address Copilot review comments on #10158
zhuqi-lucas f90e41e
Update parquet/src/arrow/push_decoder/mod.rs
zhuqi-lucas e734b3f
Update parquet/src/arrow/push_decoder/mod.rs
zhuqi-lucas c720c44
Update parquet/src/arrow/push_decoder/mod.rs
zhuqi-lucas ab77247
Update parquet/src/arrow/push_decoder/mod.rs
zhuqi-lucas 74435ca
address alamb review on #10158: peek-in-DecodingRowGroup, dedup with …
zhuqi-lucas b351ede
Merge branch 'main' into feat/peek-next-row-group
zhuqi-lucas 863ec24
add peek_remaining_row_groups, keep peek_next_row_group as early-exit…
zhuqi-lucas c64c089
test(peek): cover combined OFFSET/LIMIT, selection+budget composition…
zhuqi-lucas 4cdc6d6
simplify #10158: drop multi-value API, visitor framework, and shared …
zhuqi-lucas 8acc147
[parquet]: simplify peek next row group
alamb 52768e3
Merge remote-tracking branch 'apache/main' into feat/peek-next-row-group
alamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this
peek_remaining_row_groups()? That might enable more usages in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting it actually return more than one row group? Something like
or just rename it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am suggesting it return more than one. I'm not sure if that's helpful, but I think we have that information and if we do we might as well return it. It would avoid adding that API later and then there being overlap, but maybe it's worth doing the simpler API for now and we can always add another one later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, future work may dependent on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's file a follow on ticket to consider adding additional APIs that will expose more information. For now, the next row group is a step forward