Skip to content

Fix merge_kernels benchmark panic due to not wrapping with Scalar #10199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jun 23, 2026
Merged

Fix merge_kernels benchmark panic due to not wrapping with Scalar #10199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions arrow/benches/merge_kernels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,14 @@ fn bench_merge_on_input_generator(c: &mut Criterion, input_generator: &impl Inpu
&mut group,
&masks,
&array_1_10pct_nulls,
&non_null_scalar_1,
&Scalar::new(non_null_scalar_1.clone()),

@alamb alamb Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this panic on main with

cargo bench --bench merge_kernels --profile=dev -- array_vs_non_null_scalar
...
Benchmarking merge_8192_from_i32/array_vs_non_null_scalar/99pct_true: Warming up for 3.0000 s
thread 'main' (115764966) panicked at arrow-data/src/transform/primitive.rs:31:43:
range end index 2 out of range for slice of length 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed, to rerun pass `-p arrow --bench merge_kernels`

);

bench_merge_input_on_all_masks(
"non_null_scalar_vs_array",
&mut group,
&masks,
&non_null_scalar_1,
&Scalar::new(non_null_scalar_1.clone()),

@alamb alamb Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this panic on main with

cargo bench --bench merge_kernels --profile=dev -- non_null_scalar_vs_array
...
Benchmarking merge_8192_from_i32/non_null_scalar_vs_array/all_true: Warming up for 3.0000 s
thread 'main' (115763431) panicked at arrow-data/src/transform/primitive.rs:31:43:
range end index 8192 out of range for slice of length 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: bench failed, to rerun pass `-p arrow --bench merge_kernels`

&array_1_10pct_nulls,
);

Expand Down
Loading