Skip to content

rename Compression struct#10221

Open
Rich-T-kid wants to merge 2 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/reuse-output-buffer
Open

rename Compression struct#10221
Rich-T-kid wants to merge 2 commits into
apache:mainfrom
Rich-T-kid:rich-T-kid/reuse-output-buffer

Conversation

@Rich-T-kid

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Changed Compression context to IPCwritecontext as now its holding onto the fbb and scratch space for buffers.

What changes are included in this PR?

  • compression.rs: Renamed CompressionContext → IpcWriteContext. Added scratch: Vec field (unused for now, #[allow(dead_code)]). Added #[deprecated(since = "57.0.0", note = "Use IpcWriteContext instead")] pub type CompressionContext = IpcWriteContext; for backward compatibility.
  • writer.rs: Updated all internal type references from CompressionContext -> IpcWriteContext. Renamed all field/parameter/variable occurrences of compression_context -> ipc_write_context. Both names are re-exported from writer so existing code compiles with a deprecation warning rather than a hard error.

Are these changes tested?

n/a

Are there any user-facing changes?

@github-actions github-actions Bot added the arrow Changes to the arrow crate label Jun 26, 2026
@Rich-T-kid

Copy link
Copy Markdown
Contributor Author

cc @alamb
a follow up PR will wire together the scratch buffer and the IPCsink enum together

@github-actions github-actions Bot added the arrow-flight Changes to the arrow-flight crate label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant