Replace take_run BufferBuilders with Vec - #10631
Open
cakeni wants to merge 1 commit into
Open
Conversation
Rich-T-kid
approved these changes
Aug 11, 2026
Contributor
|
run benchmark take_kernels |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing perf/arrow-select-take-run-vecs (6d85868) to fc16607 (merge-base) diff Run configurationrun benchmark take_kernelsBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench take_kernels File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing perf/arrow-select-take-run-vecs (6d85868) to fc16607 (merge-base) diff Run configurationrun benchmark take_kernelsCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
OffsetBufferBuilder/BufferBuilderusage withVec, when possible #10245.Rationale for this change
Using
Vecinstead ofBufferBuildercan benefit from Rust's optimized vector implementation. This updates the two builders used by the run-end encoded take path.What changes are included in this PR?
BufferBuilderinstances intake_runwith preallocated vectors.ScalarBufferobjects from those vectors.BufferBuilderpath unchanged.Are these changes tested?
Yes. The following checks pass:
cargo +stable-x86_64-pc-windows-gnu fmt --all -- --checkcargo +stable-x86_64-pc-windows-gnu clippy -p arrow-select --all-targets --all-features --no-deps -- -D warningscargo +stable-x86_64-pc-windows-gnu test -p arrow-select --all-features(406 unit tests and 17 doctests passed)Are there any user-facing changes?
No.