Skip to content

Replace concat_elements_bytes BufferBuilders with Vec #10632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cakeni wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

Replace concat_elements_bytes BufferBuilders with Vec #10632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions arrow-string/src/concat_elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,26 @@ pub fn concat_elements_bytes<T: ByteArrayType>(
let left_values = left.value_data();
let right_values = right.value_data();

let mut output_values = BufferBuilder::<u8>::new(
let mut output_values = Vec::with_capacity(
left_values.len() + right_values.len()
- left_offsets[0].as_usize()
- right_offsets[0].as_usize(),
);

let mut output_offsets = BufferBuilder::<T::Offset>::new(left_offsets.len());
output_offsets.append(T::Offset::usize_as(0));
let mut output_offsets = Vec::with_capacity(left_offsets.len());
output_offsets.push(T::Offset::usize_as(0));
for (left_idx, right_idx) in left_offsets.windows(2).zip(right_offsets.windows(2)) {
output_values.append_slice(&left_values[left_idx[0].as_usize()..left_idx[1].as_usize()]);
output_values.append_slice(&right_values[right_idx[0].as_usize()..right_idx[1].as_usize()]);
output_offsets.append(T::Offset::from_usize(output_values.len()).unwrap());
output_values
.extend_from_slice(&left_values[left_idx[0].as_usize()..left_idx[1].as_usize()]);
output_values
.extend_from_slice(&right_values[right_idx[0].as_usize()..right_idx[1].as_usize()]);
output_offsets.push(T::Offset::from_usize(output_values.len()).unwrap());
}

let builder = ArrayDataBuilder::new(T::DATA_TYPE)
.len(left.len())
.add_buffer(output_offsets.finish())
.add_buffer(output_values.finish())
.add_buffer(output_offsets.into())
.add_buffer(output_values.into())
.nulls(nulls);

// SAFETY - offsets valid by construction
Expand Down
Loading