JmsIO yaml - #39818
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| dependsOn ":sdks:java:io:expansion-service:build" | ||
| dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build" | ||
| dependsOn ":sdks:java:io:debezium:expansion-service:shadowJar" | ||
| dependsOn ":sdks:java:io:messaging-expansion-service:shadowJar" |
There was a problem hiding this comment.
Consider move this to postCommitYamlIntegrationTests. The test only need to be exercised on postsubmit time. The PreCommit becomes heavier as we are adding more expansion services (and test container). Same apply to Snowflake / Kenesis / debezium
|
Assigning reviewers: R: @damccorm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
We can follow up in a subsequent PR: #39818 (comment) |
Sorry Yi, I missed this somehow! @Amar3tto please do follow up on this when you get a chance |
Successful run:
https://github.com/apache/beam/actions/runs/32357254132
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.