Skip to content

JmsIO yaml - #39818

Merged
damccorm merged 3 commits into
masterfrom
jmsio-yaml
Aug 21, 2026
Merged

JmsIO yaml#39818
damccorm merged 3 commits into
masterfrom
jmsio-yaml

Conversation

@Amar3tto

@Amar3tto Amar3tto commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Successful run:
https://github.com/apache/beam/actions/runs/32357254132


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Comment thread sdks/python/apache_beam/yaml/standard_io.yaml
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto
Amar3tto requested a review from Abacn August 20, 2026 11:05
Comment thread sdks/python/build.gradle
dependsOn ":sdks:java:io:expansion-service:build"
dependsOn ":sdks:java:io:google-cloud-platform:expansion-service:build"
dependsOn ":sdks:java:io:debezium:expansion-service:shadowJar"
dependsOn ":sdks:java:io:messaging-expansion-service:shadowJar"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider move this to postCommitYamlIntegrationTests. The test only need to be exercised on postsubmit time. The PreCommit becomes heavier as we are adding more expansion services (and test container). Same apply to Snowflake / Kenesis / debezium

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm
damccorm merged commit 88b3ee7 into master Aug 21, 2026
107 of 108 checks passed
@Abacn

Abacn commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

We can follow up in a subsequent PR: #39818 (comment)

@damccorm

Copy link
Copy Markdown
Contributor

We can follow up in a subsequent PR: #39818 (comment)

Sorry Yi, I missed this somehow! @Amar3tto please do follow up on this when you get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants