[Python] Honor fixed object detection batch size - #39953
Merged
jrmccluskey merged 1 commit intoSep 1, 2026
Merged
Conversation
Contributor
|
Assigning reviewers: R: @jrmccluskey for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #38782 and #39949.
Why
The object-detection example describes its inference batch size as fixed, but passes
inference_batch_sizetoPytorchModelHandlerTensor. That handler does not consume this keyword. It reachesModelHandlerthrough**kwargs, where it is ignored, leavingRunInferenceto use adaptiveBatchElementsdefaults.This means all four Faster R-CNN benchmark variants have been measuring an unintended batching policy since they were added.
What changed
Pass the configured size through the supported
min_batch_sizeandmax_batch_sizearguments. Setting both to the same value makesBatchElementsuse the requested fixed size, currently 8 in the benchmark configuration.This is separate from #39949 because corrected batching may change runtime. The timeout change can remain draft until a Dataflow run shows whether 30 minutes is still insufficient.
Validation
python -m py_compile sdks/python/apache_beam/examples/inference/pytorch_image_object_detection.pyyapf==0.43.0 --diffon the changed fileruff==0.15.22 check --ignore I001,UP006on the changed filegit diff --checkThe existing Python ML precommit covers
PytorchModelHandlerTensorbatching behavior.