Skip to content

Fix typo 'occured' to 'occurred' in ZipFilesTest.java - #40979

Merged
derrickaw merged 1 commit into
apache:masterfrom
siddiqueirshad:fix-typo-occurred
Nov 4, 2026
Merged

derrickaw merged 1 commit into
apache:masterfrom
siddiqueirshad:fix-typo-occurred

Conversation

@siddiqueirshad

Copy link
Copy Markdown
Contributor

This PR corrects the misspelling occured to occurred in sdks/java/core/src/test/java/org/apache/beam/sdk/util/ZipFilesTest.java.

Signed-off-by: siddiqueirshad <mohdirshad1306@gmail.com>
@github-actions github-actions Bot added java size/xs XS: <10 lines changed labels Nov 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR fixes a spelling error (occured -> occurred) in a failure assertion message within ZipFilesTest.java. The change is clean and safe to merge.

🔍 General Feedback

  • Consider also fixing the identical occured typo a few lines below on line 217 in testDirectoryCreateFailed() (fail("We expect the IOException, but it never occured");) so the whole file is consistent.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label java.
Backup reviewer: damccorm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw
derrickaw merged commit 3421a2a into apache:master Nov 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants