Repository navigation
Fix typo 'occured' to 'occurred' in ZipFilesTest.java - #40979
Merged
Merged
Conversation
Signed-off-by: siddiqueirshad <mohdirshad1306@gmail.com>
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR fixes a spelling error (occured -> occurred) in a failure assertion message within ZipFilesTest.java. The change is clean and safe to merge.
🔍 General Feedback
- Consider also fixing the identical
occuredtypo a few lines below on line 217 intestDirectoryCreateFailed()(fail("We expect the IOException, but it never occured");) so the whole file is consistent.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Contributor
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
derrickaw
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the misspelling
occuredtooccurredinsdks/java/core/src/test/java/org/apache/beam/sdk/util/ZipFilesTest.java.