Skip to content

Bind Prism JobManagement server to localhost by default - #40989

Merged
damccorm merged 1 commit into
apache:masterfrom
damccorm:prism-bind-localhost
Nov 4, 2026
Merged

damccorm merged 1 commit into
apache:masterfrom
damccorm:prism-bind-localhost

Conversation

@damccorm

@damccorm damccorm commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Bind the Prism gRPC JobManagement listener to localhost:<port> instead of :<port>, matching the Web UI listener (web.go), the Endpoint() reporting, and the documented default.

@github-actions github-actions Bot added go runners prism size/s S: 10-49 lines changed labels Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.59%. Comparing base (12bbb17) to head (a01f848).
⚠️ Report is 60 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #40989       +/-   ##
===========================================
- Coverage   79.83%   56.59%   -23.24%     
===========================================
  Files         494      877      +383     
  Lines       83575   154949    +71374     
===========================================
+ Hits        66722    87698    +20976     
- Misses      16853    65391    +48538     
- Partials        0     1860     +1860     
Flag Coverage Δ
go 29.06% <100.00%> (?)
python 80.08% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm
damccorm marked this pull request as ready for review November 4, 2026 16:00
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label go.
Backup reviewer: jrmccluskey (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the Prism JobManagement gRPC server to bind to localhost:<port> instead of :<port> (all interfaces) by default, aligning its behavior with the Web UI listener and Endpoint() reporting. A unit test assertion is also added to TestServer_Lifecycle to verify that the listener binds to a loopback IP.

🔍 General Feedback

  • Binding the local runner's unauthenticated gRPC service to loopback by default is a solid security improvement that prevents unintended exposure on external network interfaces.
  • The implementation and unit test changes are clean, idiomatic, and pass all Go, Python, and Java Prism test suites.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@shunping shunping left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@damccorm
damccorm merged commit c11c73e into apache:master Nov 4, 2026
20 checks passed
@damccorm
damccorm deleted the prism-bind-localhost branch November 4, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants