Repository navigation
Bind Prism JobManagement server to localhost by default - #40989
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40989 +/- ##
===========================================
- Coverage 79.83% 56.59% -23.24%
===========================================
Files 494 877 +383
Lines 83575 154949 +71374
===========================================
+ Hits 66722 87698 +20976
- Misses 16853 65391 +48538
- Partials 0 1860 +1860
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @shunping for label go. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
📋 Review Summary
This PR updates the Prism JobManagement gRPC server to bind to localhost:<port> instead of :<port> (all interfaces) by default, aligning its behavior with the Web UI listener and Endpoint() reporting. A unit test assertion is also added to TestServer_Lifecycle to verify that the listener binds to a loopback IP.
🔍 General Feedback
- Binding the local runner's unauthenticated gRPC service to loopback by default is a solid security improvement that prevents unintended exposure on external network interfaces.
- The implementation and unit test changes are clean, idiomatic, and pass all Go, Python, and Java Prism test suites.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Bind the Prism gRPC JobManagement listener to
localhost:<port>instead of:<port>, matching the Web UI listener (web.go), theEndpoint()reporting, and the documented default.