Skip to content

[codecov] - add codecov token to code coverage workflows - #40995

Merged
derrickaw merged 2 commits into
masterfrom
20261104_fixPrecommitPythonCodeCoverage
Nov 4, 2026
Merged

derrickaw merged 2 commits into
masterfrom
20261104_fixPrecommitPythonCodeCoverage

Conversation

@derrickaw

@derrickaw derrickaw commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Problem: Seeing this error in recent workflow runs:
info - 2026-11-04 15:17:55,182 -- Upload queued for processing complete error - 2026-11-04 15:17:55,182 -- Upload queued for processing failed: {"message":"Token required because branch is protected"}
Fix: add secret token to all workflows that use codecov

Good run: https://github.com/apache/beam/actions/runs/41877613025/job/126741276244

@github-actions github-actions Bot added build size/xs XS: <10 lines changed labels Nov 4, 2026
@derrickaw
derrickaw marked this pull request as ready for review November 4, 2026 17:45

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR adds the token: ${{ secrets.CODECOV_TOKEN }} input to the codecov/codecov-action@v7 step in beam_PreCommit_Python_Coverage.yml. The change is valid, follows the action's input schema, and is required by Codecov v4+ for authenticated coverage uploads on non-fork events (push, schedule, workflow_dispatch).

🔍 General Feedback

  • The syntax and indentation in .github/workflows/beam_PreCommit_Python_Coverage.yml are clean and accurate.
  • Other workflows using codecov/codecov-action@v7 (such as beam_PreCommit_Java.yml, beam_PreCommit_Java_Dataflow.yml, beam_PreCommit_SQL.yml, and go_tests.yml) currently omit token: ${{ secrets.CODECOV_TOKEN }} and may benefit from a similar update in a follow-up if they are experiencing the same upload authentication issue.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.24%. Comparing base (12bbb17) to head (7d9b981).
⚠️ Report is 65 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40995       +/-   ##
=============================================
- Coverage     79.83%   58.24%   -21.59%     
- Complexity        0     2277     +2277     
=============================================
  Files           494     1136      +642     
  Lines         83575   169334    +85759     
  Branches          0     1482     +1482     
=============================================
+ Hits          66722    98634    +31912     
- Misses        16853    68151    +51298     
- Partials          0     2549     +2549     
Flag Coverage Δ
go 29.06% <ø> (?)
java 75.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label build.
Backup reviewer: Amar3tto (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw
derrickaw merged commit 7b12d2c into master Nov 4, 2026
15 checks passed
@derrickaw
derrickaw deleted the 20261104_fixPrecommitPythonCodeCoverage branch November 4, 2026 18:52
@derrickaw derrickaw changed the title [codecov] - add token to precommit python coverage workflow [codecov] - add codecov token to code coverage workflows Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants