Repository navigation
[codecov] - add codecov token to code coverage workflows - #40995
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR adds the token: ${{ secrets.CODECOV_TOKEN }} input to the codecov/codecov-action@v7 step in beam_PreCommit_Python_Coverage.yml. The change is valid, follows the action's input schema, and is required by Codecov v4+ for authenticated coverage uploads on non-fork events (push, schedule, workflow_dispatch).
🔍 General Feedback
- The syntax and indentation in
.github/workflows/beam_PreCommit_Python_Coverage.ymlare clean and accurate. - Other workflows using
codecov/codecov-action@v7(such asbeam_PreCommit_Java.yml,beam_PreCommit_Java_Dataflow.yml,beam_PreCommit_SQL.yml, andgo_tests.yml) currently omittoken: ${{ secrets.CODECOV_TOKEN }}and may benefit from a similar update in a follow-up if they are experiencing the same upload authentication issue.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40995 +/- ##
=============================================
- Coverage 79.83% 58.24% -21.59%
- Complexity 0 2277 +2277
=============================================
Files 494 1136 +642
Lines 83575 169334 +85759
Branches 0 1482 +1482
=============================================
+ Hits 66722 98634 +31912
- Misses 16853 68151 +51298
- Partials 0 2549 +2549
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Problem: Seeing this error in recent workflow runs:
info - 2026-11-04 15:17:55,182 -- Upload queued for processing complete error - 2026-11-04 15:17:55,182 -- Upload queued for processing failed: {"message":"Token required because branch is protected"}Fix: add secret token to all workflows that use codecov
Good run: https://github.com/apache/beam/actions/runs/41877613025/job/126741276244