Skip to content

Validate destination paths when materializing Go SDK artifacts - #40997

Closed
damccorm wants to merge 1 commit into
apache:masterfrom
damccorm:artifact-validate-path
Closed

damccorm wants to merge 1 commit into
apache:masterfrom
damccorm:artifact-validate-path

Conversation

@damccorm

@damccorm damccorm commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Validate that staged artifact names resolve within the destination directory during artifact materialization in sdks/go/pkg/beam/artifact/materialize.go, matching the check in expansionx/download.go.

@github-actions github-actions Bot added go size/s S: 10-49 lines changed labels Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.07%. Comparing base (12bbb17) to head (10bc2c5).
⚠️ Report is 65 commits behind head on master.

Files with missing lines Patch % Lines
sdks/go/pkg/beam/artifact/materialize.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #40997       +/-   ##
===========================================
- Coverage   79.83%   29.07%   -50.76%     
===========================================
  Files         494      383      -111     
  Lines       83575    71347    -12228     
===========================================
- Hits        66722    20745    -45977     
- Misses      16853    48743    +31890     
- Partials        0     1859     +1859     
Flag Coverage Δ
go 29.07% <86.66%> (?)
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damccorm damccorm closed this Nov 4, 2026
@damccorm
damccorm deleted the artifact-validate-path branch November 4, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go size/s S: 10-49 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant