Remove stale keys in OrderedProperties compute and merge#702
Merged
garydgregory merged 1 commit intoJul 4, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jul 4, 2026
garydgregory
added a commit
that referenced
this pull request
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OrderedPropertieskeeps a parallelorderedKeysset that backskeys(),keySet(),entrySet()andtoString(), butcompute()andmerge()only ever add to it. both operations remove the mapping from the backingHashtablewhen the remapping function returnsnull, so aftercompute(key, (k, v) -> null)on a present key the mapping is gone yet the key still shows up inkeySet(),size()disagrees with the key view, andtoString()throwsNullPointerExceptionon the stale key's null value.remove the key from
orderedKeyswhen the result isnull. aHashtablenever stores null values, so a null result means the mapping was removed, which is what the existingremove()overrides already do. found while auditing the ordered-view bookkeeping against thePropertiescontract;SortedPropertiesderives its keys live fromsuper.keySet()and needs no change.