ci(breaking-change-detector): don't use maintain-one-comment and instead do it manually#22568
Merged
Merged
Conversation
the comment for breaking change detector looks broken since last success was 8 days ago
github-actions
Bot
added
common
github-actions
Bot
added
development-process
rluvaton
changed the title
maintain-one-comment and instead do it manually
Member
Author
|
@Jefffrey can you please review this real quick? |
Member
Author
|
@alamb maybe can you review? |
alamb
approved these changes
May 28, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Sure -- let's try it. Thanks for trying to keep things moving. It is hard to keep all this stuff maintained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the comment and label for breaking change detector is not working for 8 days already, (it was noticed by @neilconway)
after searching the issue is that
actions-cool/maintain-one-commentthat we used was compromised and was removed from github.we did not used the malicious commit fortunately.
this change the comment logic to be manual instead of using that action
See more:
Issue to remove the action from asf allow list: