fix(sort): record output_batches, output_bytes and end_time for when not using merge sort#22878
Merged
Conversation
…not using merge sort
kosiew
reviewed
Jun 17, 2026
Contributor
There was a problem hiding this comment.
@rluvaton
This looks good to me. The final SortExec output stream now records the baseline output_rows, output_batches, output_bytes, and end_time exactly once, including the fast paths that skip StreamingMergeBuilder. I only have a couple of small cleanup suggestions to make that invariant easier to preserve.
kosiew
approved these changes
Jun 17, 2026
Contributor
|
Shall we merge this PR? It seems to have some conflicts |
Contributor
|
@rluvaton |
# Conflicts: # datafusion/physical-plan/src/sorts/multi_level_merge.rs # datafusion/physical-plan/src/sorts/sort.rs
Member
Author
|
I hate GitHub Notifications, I miss so many fixed comments and conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
When only using in mem sort without going through the
StreamingMergeBuildersome metrics are not being recordedWhat changes are included in this PR?
wrap in
ObservedStreamfor streams that returned to the next operatorAre these changes tested?
yes
Are there any user-facing changes?
no